Runtime Tableauization for Rosenbrock Methods#3208
Closed
KeshavVenkatesh wants to merge 1 commit intoSciML:masterfrom
Closed
Runtime Tableauization for Rosenbrock Methods#3208KeshavVenkatesh wants to merge 1 commit intoSciML:masterfrom
KeshavVenkatesh wants to merge 1 commit intoSciML:masterfrom
Conversation
Member
|
This was supersceded by #3102, which also handles the generic rosenbrock generated code. |
Member
|
But there's still tons of other methods to do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ChrisRackauckas
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This PR attempts to implement the runtime tableauization for Rosenbrock methods. The new tests I have written have passed. Here are the results:
Test Summary: | Pass Total Time
GenericRosenbrock Basic Solve | 14 14 4.1s
Test Summary: | Pass Total Time
GenericRosenbrock Interpolation | 63 63 4.6s
Test Summary: | Pass Total Time
GenericRosenbrock L2 Convergence - Scalar | 7 7 1.0s
Test Summary: | Pass Total Time
GenericRosenbrock L2 Convergence - Vector | 7 7 1.5s
Test Summary: | Pass Total Time
GenericRosenbrock Matches Specialized Solvers | 49 49 4.0s
Test Summary: | Pass Total Time
GenericRosenbrock Dense Output | 85 85 0.6s
I will work on comparing the efficiency of the run-time vs. compile-time approaches.